Some adaptations to workflows #9994
Open
+496
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
2 times, most recently
from
e38fc26 to
16d8860
Compare
CodSpeed Performance ReportMerging #9994 will not alter performanceComparing Summary
|
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
3 times, most recently
from
a1fc9a1 to
ab916da
Compare
oyvindeide
reviewed
Feb 9, 2025
src/ert/cli/workflow.py
Outdated
| runner = WorkflowRunner( | ||
| workflow=workflow, | ||
| storage=storage, | ||
| ert_config=ert_config, |
There was a problem hiding this comment.
I guess we should remove this as it is not available in run models, where most of these are run from?
| if is_using_wf_args_fixture | ||
| else [*workflow_args, *fixture_args] | ||
| ) | ||
| if not positional_args and not use_kwargs: |
There was a problem hiding this comment.
This we could keep this as it used to be? I dont think kwargs were really supported before, they just ended up being workflow_args in a list?
src/ert/workflow_runner.py
Outdated
| @@ -107,14 +107,16 @@ class WorkflowRunner: | |||
| def __init__( | |||
| self, | |||
| workflow: Workflow, | |||
| config_file: str | None = None, | |||
There was a problem hiding this comment.
Also commented in semeio, could potentially give reports dir, we do something similar for the update report, that has a folder it writes to.
src/ert/workflow_runner.py
Outdated
| storage: Storage | None = None, | ||
| ensemble: Ensemble | None = None, | ||
| ert_config: ErtConfig | None = None, | ||
| ) -> None: | ||
| self.__workflow = workflow | ||
| self.storage = storage | ||
| self.ensemble = ensemble | ||
| self.ert_config = ert_config | ||
| self.ert_config = ert_config # Should eventually be removed |
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
8 times, most recently
from
a60c42c to
6e47da3
Compare
jonathan-eq
reviewed
Feb 11, 2025
jonathan-eq
reviewed
Feb 11, 2025
jonathan-eq
reviewed
Feb 11, 2025
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
3 times, most recently
from
87c7ada to
0aeee68
Compare
jonathan-eq
requested changes
Feb 11, 2025
9 tasks
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
from
0aeee68 to
9d1a66e
Compare
|
There seems to be a GUI test hanging now 🤔 |
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
from
b828aa7 to
f094ca8
Compare
Co-authored-by: Jonathan Karlsen <[email protected]>
Co-authored-by: Jonathan Karlsen <[email protected]>
Co-authored-by: Jonathan Karlsen <[email protected]>
yngve-sk
force-pushed
the
25.02.05.internal-workflows-pass-some-stuff
branch
from
f094ca8 to
1e668d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves equinor/semeio#685
Add support for defaulted kwargs from workflows